By reading your code, I suspect two places that might cause problems.
The first one:
// Define LINQ for all WOMs of Loan except WOM being updated
var wom = from o in crm.OpportunitySet
where o.CustomerId == opp.CustomerId && o.OpportunityId != opp.OpportunityId
select o;
Now your wom is of type IQueryable<Opportunity>, by definition of IQueryable, the elements are actually not retrieved here yet. They are fetched only when you enumerating through the IQueryable object. So, depending on the CRM IQueryable
provider implementation, modifying the elements while iterating through the IQueryable could cause an inconsistent state error. I will try to illustrate the steps with an imaginary IQuerable implementation.
Time 1:
1. execute the code var wom = ... create an expression tree that can be used to fetch items later.
2. LINQ provider remembers express tree creation time as T1
Time 2:
1. get the first element from wom, which will cause the expression tree to be evaluated and ask the web service for one element.
2. modify it and call context.SaveChanges,
3. Context remembers last web service change time as T2
Time 3:
1. try to get second element from wom, cause the expression tree to be evaluated, ask web service for one element, but since the expression tree creation time T1 < web service change time T2. The IQueryble become "dirty" can not usable,
throw an exception
To avoid the senario described above, simply modify
var wom = from o in crm.OpportunitySet
where o.CustomerId == opp.CustomerId && o.OpportunityId != opp.OpportunityId
select o;
to
var wom = (from o in crm.OpportunitySet
where o.CustomerId == opp.CustomerId && o.OpportunityId != opp.OpportunityId
select o).ToList();
This way, you are keeping a list of items instead of an expression tree in member and the "dirty" state won't occur.
The second place that may cause trouble is
foreach (var w in wom)
{
if (w.new_IsPrimary == true)
{
// Make any primary records, non-primary
//**********************************************************************************
w.new_IsPrimary = false;
crm.UpdateObject(w);
crm.SaveChanges(); //performance problem?
//**********************************************************************************
}
} // foreach
The ServiceContext.SaveChanges() method will cause context send all the changes to web service. So, if we had 1000 items in wom, we will do this round trip 1000 times. I believe move crm.SaveChanges() out of foreach loop can save a lot of round trip and
may even solve your error of inconsistent state,(The last updated time only updates after all the items are be modified)
I am on a mac right now and have no way to test my suggestions. Please let me know if they are valid.
Cheers,
Wei
