locked
A possible mistake in the comment of systable.asm RRS feed

  • Question

  • In the comment just after the copyright header:

    ;
    ; To add a system service simply add the name of the service to the below
    ; table. If the system service has arguments, then immediately
    ; follow the name of the serice with a comma and following that the number
    ; of bytes of in memory arguments, e.g. CreateObject,40.
    ;

    I read the macro that perform the actual work and found that the number of ARGUMENTS should be given instead of the number of bytes. The macro will do the calculation.

    I am using WRK v1.2.

    Please confirm if I am correct. Thanks.
    Thursday, May 3, 2007 1:10 PM

Answers

  • Yes.  The comment is out of date.  It was fixed for AMD64, but not for i386.  Thanks.
    Saturday, May 5, 2007 1:57 AM

All replies

  • Hi Yu-Ning-

     

    I've forwarded this on to a kernel architect to take a look at the comments and confirm what you've found.

     

    Thanks.

    Brian

    Friday, May 4, 2007 5:56 PM
  • Yes.  The comment is out of date.  It was fixed for AMD64, but not for i386.  Thanks.
    Saturday, May 5, 2007 1:57 AM
  • Oh, I forgot to point out the directory. Sorry.
    Thanks, Brian and Dave.
    Saturday, May 5, 2007 4:34 AM